1130515 - Suite needs to register the nsIDownloadManager implementation of nsITransfer since toolkit doesn't do that any more.

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Philip Chee]

See Bug 1114624 - Don't register the legacy nsIDownloadManager implementation of nsITransfer by default any more

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix

(From Bug 1114624 comment #0)

> Now that all the core applications have migrated to Downloads.jsm, we should
> actively remove uses of nsIDownloadManager. The first step is to register
> the JavaScript implementation of nsITransfer, avoiding to register the
> legacy nsIDownloadManager implementation and letting external applications
> do that if needed.
> 
> The override required in applications that still use nsIDownloadManager
> would be implemented at startup using a technique similar to the one removed
> by the patch.
> 
> The legacy CID and the contract ID are defined as NS_DOWNLOAD_CID and
> NS_TRANSFER_CONTRACTID, and they are
> "{b02be33b-d47c-4bd3-afd9-402a942426b0}" and "@mozilla.org/transfer;1"
> respectively.

Comment 2

[[e-mail]]

Comment on attachment 8560878 [details] [diff] [review]
Patch v1.0 Proposed fix

We've actually already got an opt-out of the download manager ui component.

Comment 3

[Philip Chee]

(In reply to [e-mail] from comment #2)
> Comment on attachment 8560878 [details] [diff] [review]
> Patch v1.0 Proposed fix
> 
> We've actually already got an opt-out of the download manager ui component.
Well the next step would be to remove the |if not CONFIG['MOZ_SUITE']:| from:
<http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/downloads/moz.build?rev=6c0cfdafc568#46>

Comment 4

[Philip Chee]

>> We've actually already got an opt-out of the download manager ui component.
> Well the next step would be to remove the |if not CONFIG['MOZ_SUITE']:| from:
> <http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/
> downloads/moz.build?rev=6c0cfdafc568#46>
Come to think of it, the new Firefox JS Downloads implementation doesn't use these files either.

Comment 5

[Philip Chee]

Attachment: Patch v2 Only register nsITransfer

Comment 7

[Philip Chee]

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/e14324aa656c