Closed Bug 1130515 Opened 9 years ago Closed 9 years ago

Suite needs to register the nsIDownloadManager implementation of nsITransfer since toolkit doesn't do that any more.

Categories

(SeaMonkey :: Download & File Handling, defect)

defect
Not set
normal

Tracking

(seamonkey2.35 fixed)

RESOLVED FIXED
seamonkey2.35
Tracking Status
seamonkey2.35 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file, 1 obsolete file)

See Bug 1114624 - Don't register the legacy nsIDownloadManager implementation of nsITransfer by default any more
Attached patch Patch v1.0 Proposed fix (obsolete) — Splinter Review
(From Bug 1114624 comment #0)

> Now that all the core applications have migrated to Downloads.jsm, we should
> actively remove uses of nsIDownloadManager. The first step is to register
> the JavaScript implementation of nsITransfer, avoiding to register the
> legacy nsIDownloadManager implementation and letting external applications
> do that if needed.
> 
> The override required in applications that still use nsIDownloadManager
> would be implemented at startup using a technique similar to the one removed
> by the patch.
> 
> The legacy CID and the contract ID are defined as NS_DOWNLOAD_CID and
> NS_TRANSFER_CONTRACTID, and they are
> "{b02be33b-d47c-4bd3-afd9-402a942426b0}" and "@mozilla.org/transfer;1"
> respectively.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8560878 - Flags: review?(neil)
Comment on attachment 8560878 [details] [diff] [review]
Patch v1.0 Proposed fix

We've actually already got an opt-out of the download manager ui component.
Attachment #8560878 - Flags: review?(neil) → review-
(In reply to neil@parkwaycc.co.uk from comment #2)
> Comment on attachment 8560878 [details] [diff] [review]
> Patch v1.0 Proposed fix
> 
> We've actually already got an opt-out of the download manager ui component.
Well the next step would be to remove the |if not CONFIG['MOZ_SUITE']:| from:
<http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/downloads/moz.build?rev=6c0cfdafc568#46>
>> We've actually already got an opt-out of the download manager ui component.
> Well the next step would be to remove the |if not CONFIG['MOZ_SUITE']:| from:
> <http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/
> downloads/moz.build?rev=6c0cfdafc568#46>
Come to think of it, the new Firefox JS Downloads implementation doesn't use these files either.
Attachment #8560878 - Attachment is obsolete: true
Attachment #8563436 - Flags: review?(neil)
Attachment #8563436 - Flags: review?(neil) → review+
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/e14324aa656c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: